Extend internationalization package with SSR and CSR and the ability to store selected language in cookies - #2
Merged
Conversation
added 13 commits
October 7, 2020 08:41
…s into one single class
| * @param language { string } - Language to set | ||
| * @param cookieName { string } - Optional: Cookie name | ||
| */ | ||
| static setLanguage(language: string, cookieName?: string): void { |
Member
There was a problem hiding this comment.
Do we need this static function?
Author
There was a problem hiding this comment.
I thought this method could be useful to quickly change the language without having to create a new instance
Member
There was a problem hiding this comment.
I would leave it out for now and add it only if see a need for it.
stplasim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend internationalization package with SSR and CSR and the ability to store selected language in cookies
Todos:
CSR: Get browser language
CSR: Store language in cookie
CSR: Get language form cookie
SSR: Get browser language
SSR: Store language in cookie
SSR: Get language form cookie